glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Fix path check for minified JS/CSS files

Open cedric-anne opened this issue 2 months ago • 5 comments

Checklist before requesting a review

  • [x] I have read the CONTRIBUTING document.
  • [x] I have performed a self-review of my code.

Description

Minified JS/CSS files are in the /public directory.

It closes #22208.

cedric-anne avatar Dec 03 '25 16:12 cedric-anne

This wouldnt work for plugins, would it?

cconard96 avatar Dec 03 '25 16:12 cconard96

This wouldnt work for plugins, would it?

Indeed.

cedric-anne avatar Dec 03 '25 16:12 cedric-anne

Something similar would need done for csPath too. I noticed it yesterday while working on the RTL CSS PR.

cconard96 avatar Dec 04 '25 14:12 cconard96

Something similar would need done for csPath too. I noticed it yesterday while working on the RTL CSS PR.

Indeed, I fixed it in my last commit.

cedric-anne avatar Dec 11 '25 13:12 cedric-anne

Tests are failing

trasher avatar Dec 12 '25 06:12 trasher

Minified files were not commited due to .gitignore rules, this is why tests were passing on my machine but non on the CI context.

cedric-anne avatar Dec 16 '25 20:12 cedric-anne