glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Feat(Inventory): Basic auth for Agent

Open MyvTsv opened this issue 1 year ago • 3 comments

Checklist before requesting a review

Please delete options that are not relevant.

  • [x] I have read the CONTRIBUTING document.
  • [x] I have performed a self-review of my code.
  • [x] I have added tests that prove my fix is effective or that my feature works.

Description

Implement Basic Auth form for inventory endpoint

Screenshots (if appropriate):

Capture d’écran du 2024-09-11 15-00-48

MyvTsv avatar Sep 11 '24 13:09 MyvTsv

$DB->commit() should not be used I was able to check that the configuration had been saved correctly

stonebuzz avatar Oct 01 '24 11:10 stonebuzz

I think there should be a warning displayed when trying to use basic authentication. It really should never be used, except as a short-term solution for anyone that was handling this at the web server level previously until they are able to switch to using OAuth.

cconard96 avatar Oct 02 '24 11:10 cconard96

I think there should be a warning displayed when trying to use basic authentication. It really should never be used, except as a short-term solution for anyone that was handling this at the web server level previously until they are able to switch to using OAuth.

If we warn about using an unsecure auth mechanism, we have to warn about using default no auth at all one. I wonder if a better place would be in documentation.

trasher avatar Oct 02 '24 13:10 trasher