glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Add Custom Asset to ITIL Link Types from Definition

Open cconard96 opened this issue 1 year ago • 5 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

Selection_362

cconard96 avatar Aug 12 '24 19:08 cconard96

The design seems a bit odd to me, I said the same thing yesterday in Caen office (I forgot to write my opinion since) I'm not a big fan of the "Show extra fields" toggle that seems to be here to hide the mess under :p

Some suggestions:

  • maybe we could find a shorter label and try to include it in the main rows
  • otherwise, maybe align the thing to the left, and remove the border-bottom of the above rows

In both cases, the top toggle seems not useful

orthagh avatar Aug 21 '24 09:08 orthagh

* maybe we could find a shorter label and try to include it in the main rows

I tried that first. It seemed messy to handle the display of the checkbox matrix and handling the permissions on the server side. It also means that we have a lot of horizontal scrolling. Finally, I don't know how many options like this we will end up adding (or have plugins add), but maybe not all can be displayed as a checkbox.

* otherwise, maybe align the thing to the left, and remove the border-bottom of the above rows

The alignment wasn't intentional, but it does help show that it is part of the Profile listed above it. Removing the border is a good idea. It would require some changes to the checkbox matrix template to allow it.

In both cases, the top toggle seems not useful

It was just a way to hide the extra fields if the interest is only in the basic permissions. If you have a lot of Profiles and/or if we add a lot more of these extra fields, it could be a lot of scrolling to find the Profiles you want without using the browser search. Maybe a search box to filter the displayed Profiles would be better?

cconard96 avatar Aug 21 '24 10:08 cconard96

And what about displaying a unique field at the end of the rights matrix that would permit to select the list of profiles that should be able to use this kind of asset in ITIL context ?

cedric-anne avatar Aug 21 '24 14:08 cedric-anne

maybe an idea yes. Note sure atm, but I take other opinions

orthagh avatar Aug 21 '24 14:08 orthagh

ping @orthagh

What should we do with this PR?

cedric-anne avatar Sep 18 '24 14:09 cedric-anne

Here is the popularity of my request :p

So let's go for a unified multiple dropdown where you select profiles that can assign items. It will take reduced space and it should be a better experience.

orthagh avatar Dec 03 '24 14:12 orthagh

So for this one, apart from fixing tests, We may review the label a bit. I suggest: "Profiles that can associate %s with tickets, problems or changes", where %s is the asset name/label

orthagh avatar Dec 05 '24 08:12 orthagh