glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Add AdditionalTargets For SoftwareLicense Alert

Open tsmr opened this issue 1 year ago • 2 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #number

Add AdditionalTargets For SoftwareLicense Alert

tsmr avatar Jun 26 '24 10:06 tsmr

I understand. Like certificates, recipients of the alert will receive all expired certificates and not just those for which they are responsible?

tsmr avatar Jun 26 '24 15:06 tsmr

My point is that this code will not work. Indeed, the notification is created by NotificationEvent::raiseEvent('alert', new self(), $options), meaning that the $target_object of the NotificationTarget will be an empty SoftwareLicense item. The id of the tech/group in charge is fetched from this $target_object, so this id will always be unset/0.

cedric-anne avatar Jun 26 '24 21:06 cedric-anne

This PR seems stale, I close it.

cedric-anne avatar Jan 16 '25 14:01 cedric-anne