glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Exclude some itemtypes from locked fields management

Open trasher opened this issue 1 year ago • 3 comments

Q A
Bug fix? yes/no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes

Maybe in addition with #17305 if it really improves the query.

I'm not sure we really need to handle locks on Device*; and there are probably other itemtypes that can be excluded (I'm surprised we do not hear from Software* for example).

trasher avatar Jun 17 '24 07:06 trasher

(note: I've not yet added tests, I'll do if you think that change makes sense)

trasher avatar Jun 17 '24 07:06 trasher

after a quick test of the PR, the values modified by hand are not overwritten by the inventory (e.g. inventory number, manufacturer, etc.)

I don't really know what to make of it,

no major impact, better performance, but we lose the visual information that a value has been changed manually (with the padlock)

stonebuzz avatar Jul 01 '24 06:07 stonebuzz

OK, thanks for your feedback. Maybe a better solution would be users can configure what they exclude from locks?

This would be more complex that my current proposition, but it would maybe fit better for everyone usage. Of course, it would target main branch.

trasher avatar Jul 01 '24 07:07 trasher