glpi-project
fix(notifications): actor replacement
On a ticket, when an assigned group was replaced by another, the notification was sent to the deleted group, and in the message content the old group was displayed as still assigned.
EDIT : same for users
This was because the notification was sent after the new group had been added to the database, but before the old group had been deleted.
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | !29660 #14704 |
After irl discussion:
- shoult target main branch
- I guess 6 month after release, someone will want the inverse behavior, so: provide a new notification for deletion of actors (and copy the same recipients as the former)
If this PR targets main, i.e. 10.1.x, it doesn't correct the case on the current version.
In this case, how to fix it on 10.0/bugfixes?
I have 2 customers who have reported this problem on 10.0 : !29660 + !30331
I still think that notifying the deleted actor as if he were still an active actor in the ticket is a bug and should be treated as bugfixes.
I would point out that with the 2nd commit, the status doesn't change, it's not temporarily in "in coming".
