glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Delegate validation

Open btry opened this issue 3 years ago • 6 comments

requires :

  • #12486

internal ref: 23396

Feature 1: select the responsible of the requester to request for validation

When there are several requesters , only the 1st user found (ordered by ID of ticket_user relation) is added in the dropdown

image

Feature 2: users may choose substitutes to delegate validation to them.

A date range restricts the effect of the delegation. It is possible to nave no date limitation, only a beginning date , only a end date, or both.

image

image

Additions for rebase of this PR onto main branch

In main branch I see that we can set a group as validator. The column user_id_actual_validate brings additional value here as it records the user who actually validate the ITIL object.

I added support for resolution of substitute against validator group.

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #number

btry avatar Aug 26 '22 14:08 btry

@cconard96 : I updated the date range check to handle unset values. I also added a check to forbid a end date being older than the start date.

btry avatar Aug 29 '22 16:08 btry

Some changes are planned

  • replace the read only multiselect with a table to show start / end dates of delegation image
  • show the name of the responsible in validation request image
  • allow loop between validator substitute and valdiation delegator (currently forbidden by code)

btry avatar Aug 30 '22 08:08 btry

Do not forget to change codebase to main.

trasher avatar Aug 30 '22 12:08 trasher

This is in progress. I'm rewriting the history of the branch to make easier to solve conflicts with main branch. I put this PR as WIP.

btry avatar Aug 30 '22 12:08 btry

You should change PR to draft

trasher avatar Aug 30 '22 12:08 trasher

Hi, the pr is ready for review @cconard96 @AdrienClairembault @cedric-anne @trasher

btry avatar Sep 08 '22 09:09 btry

@orthagh As discussed, I moved the requester supervisors in the users dropdown. Now we can handle the supervisor of several requesters.

image

image

btry avatar Oct 17 '22 12:10 btry

substitutes tab now handles singular / plural and shows count of substitutes image

btry avatar Oct 17 '22 12:10 btry

hi, is this feature usable in glpi 10.0.7? thank you.

JohnnyMacao avatar Jun 26 '23 09:06 JohnnyMacao