glpi icon indicating copy to clipboard operation
glpi copied to clipboard

Impossible to reorder Kanban's tasks

Open SteadEXE opened this issue 2 years ago • 10 comments

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • [X] I have searched the existing issues

Version

10.0.2

Bug description

Some tasks change their position in kanban view, or it's not saved properly. It may be related to some state getting loaded to the right side modal, corrupting or injecting some bad state into the task.

Relevant log output

sql-errors.log:

[2022-07-08 14:32:43] glpisqllog.ERROR: DBmysql::query() in E:\GLPI\src\DBmysql.php line 370
  *** MySQL query error:
  SQL: INSERT INTO `glpi_projecttaskteams` (`projecttasks_id`, `itemtype`, `items_id`) VALUES ('144', 'User', '7')
  Error: Duplicate entry '144-User-7' for key 'unicity'
  Backtrace :
  src\DBmysql.php:1312                               
  src\CommonDBTM.php:705                             DBmysql->insert()
  src\CommonDBTM.php:1304                            CommonDBTM->addToDB()
  src\ProjectTask.php:2093                           CommonDBTM->add()
  ajax\kanban.php:255                                ProjectTask->addTeamMember()

Page URL

front/project.form.php

Steps To reproduce

  1. Create a project
  2. Create task 1 from kanban
  3. Create task 2 from kanban
  4. Create task 3 from kanban
  5. Create task 4 from kanban
  6. I don't know if it creates the issue or not but affect a user to task 2
  7. Affect same user to task 3
  8. Move task 4 between task 1 and 2
  9. Refresh or wait the kanban to refresh.
  10. Voilà

Your GLPI setup information

Informations sur le système, l'installation et la configuration
GLPI 10.0.2 ( => E:\GLPI)
Installation mode: TARBALL
Current language:fr_FR
Server
 
Operating system: Windows NT SRVGLPI10 10.0 build 17763 (Windows Server 2019) AMD64
PHP 8.1.6 cgi-fcgi (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, bcmath, bz2, calendar, cgi-fcgi, ctype, curl,
	date, dom, exif, fileinfo, filter, gd, hash, iconv, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre,
	readline, session, sodium, standard, tokenizer, xml, xmlreader, xmlwriter, zip, zlib)
Setup: max_execution_time="30" memory_limit="256M" post_max_size="2048M" safe_mode="" session.save_handler="files"
	upload_max_filesize="2048M" 
Software: Microsoft-IIS/10.0
	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.5060.114 Safari/537.36
Server Software: mariadb.org binary distribution
	Server Version: 10.8.3-MariaDB
	Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
	Parameters: glpi@localhost/glpi
	Host info: localhost via TCP/IP

PHP version (8.1.6) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed. gd extension is installed. intl extension is installed. libxml extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.8.3) is supported. The log file has been created successfully. Write access to E:\GLPI/files/_cache has been validated. Write access to E:\GLPI/config has been validated. Write access to E:\GLPI/files/_cron has been validated. Write access to E:\GLPI/files has been validated. Write access to E:\GLPI/files/_dumps has been validated. Write access to E:\GLPI/files/_graphs has been validated. Write access to E:\GLPI/files/_lock has been validated. Write access to E:\GLPI/files/_pictures has been validated. Write access to E:\GLPI/files/_plugins has been validated. Write access to E:\GLPI/files/_rss has been validated. Write access to E:\GLPI/files/_sessions has been validated. Write access to E:\GLPI/files/_tmp has been validated. Write access to E:\GLPI/files/_uploads has been validated. Web access to files directory is protected exif extension is installed. ldap extension is installed. openssl extension is installed. zip extension is installed. bz2 extension is installed. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to E:\GLPI/marketplace has been validated. Timezones seems loaded in database.

GLPI constants
 
GLPI_ROOT: E:\GLPI
GLPI_CONFIG_DIR: E:\GLPI/config
GLPI_VAR_DIR: E:\GLPI/files
GLPI_MARKETPLACE_DIR: E:\GLPI/marketplace
GLPI_USE_CSRF_CHECK: 1
GLPI_CSRF_EXPIRES: 7200
GLPI_CSRF_MAX_TOKENS: 100
GLPI_USE_IDOR_CHECK: 1
GLPI_IDOR_EXPIRES: 7200
GLPI_ALLOW_IFRAME_IN_RICH_TEXT: 
GLPI_TELEMETRY_URI: https://telemetry.glpi-project.org
GLPI_INSTALL_MODE: TARBALL
GLPI_NETWORK_MAIL: [email protected]
GLPI_NETWORK_SERVICES: https://services.glpi-network.com
GLPI_MARKETPLACE_ALLOW_OVERRIDE: 1
GLPI_MARKETPLACE_MANUAL_DOWNLOADS: 1
GLPI_USER_AGENT_EXTRA_COMMENTS: 
GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: 1
GLPI_AJAX_DASHBOARD: 1
GLPI_CALDAV_IMPORT_STATE: 0
GLPI_DEMO_MODE: 0
GLPI_CENTRAL_WARNINGS: 1
GLPI_DOC_DIR: E:\GLPI/files
GLPI_CACHE_DIR: E:\GLPI/files/_cache
GLPI_CRON_DIR: E:\GLPI/files/_cron
GLPI_DUMP_DIR: E:\GLPI/files/_dumps
GLPI_GRAPH_DIR: E:\GLPI/files/_graphs
GLPI_LOCAL_I18N_DIR: E:\GLPI/files/_locales
GLPI_LOCK_DIR: E:\GLPI/files/_lock
GLPI_LOG_DIR: E:\GLPI/files/_log
GLPI_PICTURE_DIR: E:\GLPI/files/_pictures
GLPI_PLUGIN_DOC_DIR: E:\GLPI/files/_plugins
GLPI_RSS_DIR: E:\GLPI/files/_rss
GLPI_SESSION_DIR: E:\GLPI/files/_sessions
GLPI_TMP_DIR: E:\GLPI/files/_tmp
GLPI_UPLOAD_DIR: E:\GLPI/files/_uploads
GLPI_INVENTORY_DIR: E:\GLPI/files/_inventories
GLPI_NETWORK_REGISTRATION_API_URL: https://services.glpi-network.com/api/registration/
GLPI_MARKETPLACE_PLUGINS_API_URI: https://services.glpi-network.com/api/glpi-plugins/
GLPI_I18N_DIR: E:\GLPI/locales
GLPI_VERSION: 10.0.2
GLPI_SCHEMA_VERSION: 10.0.2@a130db99c7d9b131c2e2ea59fe0d6260fe93d831
GLPI_MARKETPLACE_PRERELEASES: 
GLPI_MIN_PHP: 7.4.0
GLPI_MAX_PHP: 8.2.0
GLPI_YEAR: 2022
Libraries
 
htmlawed/htmlawed version 1.2.6 in (E:\GLPI\vendor\htmlawed\htmlawed)
phpmailer/phpmailer version 6.6.0 in (E:\GLPI\vendor\phpmailer\phpmailer\src)
simplepie/simplepie version 1.5.8 in (E:\GLPI\vendor\simplepie\simplepie\library)
tecnickcom/tcpdf version 6.4.4 in (E:\GLPI\vendor\tecnickcom\tcpdf)
michelf/php-markdown in (E:\GLPI\vendor\michelf\php-markdown\Michelf)
true/punycode in (E:\GLPI\vendor\true\punycode\src)
iamcal/lib_autolink in (E:\GLPI\vendor\iamcal\lib_autolink)
sabre/dav in (E:\GLPI\vendor\sabre\dav\lib\DAV)
sabre/http in (E:\GLPI\vendor\sabre\http\lib)
sabre/uri in (E:\GLPI\vendor\sabre\uri\lib)
sabre/vobject in (E:\GLPI\vendor\sabre\vobject\lib)
laminas/laminas-i18n in (E:\GLPI\vendor\laminas\laminas-i18n\src)
laminas/laminas-servicemanager in (E:\GLPI\vendor\laminas\laminas-servicemanager\src)
monolog/monolog in (E:\GLPI\vendor\monolog\monolog\src\Monolog)
sebastian/diff in (E:\GLPI\vendor\sebastian\diff\src)
donatj/phpuseragentparser in (E:\GLPI\vendor\donatj\phpuseragentparser\src\UserAgent)
elvanto/litemoji in (E:\GLPI\vendor\elvanto\litemoji\src)
symfony/console in (E:\GLPI\vendor\symfony\console)
scssphp/scssphp in (E:\GLPI\vendor\scssphp\scssphp\src)
laminas/laminas-mail in (E:\GLPI\vendor\laminas\laminas-mail\src\Protocol)
laminas/laminas-mime in (E:\GLPI\vendor\laminas\laminas-mime\src)
rlanvin/php-rrule in (E:\GLPI\vendor\rlanvin\php-rrule\src)
blueimp/jquery-file-upload in (E:\GLPI\vendor\blueimp\jquery-file-upload\server\php)
ramsey/uuid in (E:\GLPI\vendor\ramsey\uuid\src)
psr/log in (E:\GLPI\vendor\psr\log\Psr\Log)
psr/simple-cache in (E:\GLPI\vendor\psr\simple-cache\src)
psr/cache in (E:\GLPI\vendor\psr\cache\src)
league/csv in (E:\GLPI\vendor\league\csv\src)
mexitek/phpcolors in (E:\GLPI\vendor\mexitek\phpcolors\src\Mexitek\PHPColors)
guzzlehttp/guzzle in (E:\GLPI\vendor\guzzlehttp\guzzle\src)
guzzlehttp/psr7 in (E:\GLPI\vendor\guzzlehttp\psr7\src)
glpi-project/inventory_format in (E:\GLPI\vendor\glpi-project\inventory_format\lib\php)
wapmorgan/unified-archive in (E:\GLPI\vendor\wapmorgan\unified-archive\src)
paragonie/sodium_compat in (E:\GLPI\vendor\paragonie\sodium_compat\src)
symfony/cache in (E:\GLPI\vendor\symfony\cache)
html2text/html2text in (E:\GLPI\vendor\html2text\html2text\src)
symfony/css-selector in (E:\GLPI\vendor\symfony\css-selector)
symfony/dom-crawler in (E:\GLPI\vendor\symfony\dom-crawler)
twig/twig in (E:\GLPI\vendor\twig\twig\src)
twig/string-extra in (E:\GLPI\vendor\twig\string-extra)
symfony/polyfill-ctype not found
symfony/polyfill-iconv not found
symfony/polyfill-mbstring not found
symfony/polyfill-php80 not found
symfony/polyfill-php81 not found
LDAP directories
 
Server: 'ldap://srvadsel01', Port: '389', BaseDN: 'DC=spurgin,DC=local', Connection filter: none, RootDN: 'CN=glpisvc,OU=Compte
		Service,OU=Z_GENERIQUE,DC=spurgin,DC=local', Use TLS: none
SQL replicas
 
Not active
Notifications
 
Way of sending emails: SMTP ([email protected])
Plugins list
 
	glpiinventory        Name: GLPI Inventory                 Version: 1.0.3      State: Enabled                                 
		Install Method: Manual

Anything else?

No response

SteadEXE avatar Jul 08 '22 12:07 SteadEXE

The log entry doesn't seem related to the ordering issue. For the issue in the logs, it should be fixed by #12186.

cconard96 avatar Jul 11 '22 13:07 cconard96

Logs is fixed by https://github.com/glpi-project/glpi/pull/12186 Indeed ordering get not fixed

SteadEXE avatar Jul 12 '22 06:07 SteadEXE

I was able to play a little bit with it, there is no SQL error so far or PHP error. I really don't know why they are reordering.

I am too new with GLPI code to understand exactly what is happening.

SteadEXE avatar Jul 18 '22 13:07 SteadEXE

Apparently in Item_Kanban.php: array_splice($state[$new_column_index]['cards'], $position, 0, $card); is never reached.

I tried to dump $all_columns and $new_column_index and the conditions are not met. I guess the issue comes from there, there is no code that can reorder the array somewhere else.

I am moving cards from column "Nouveau" which is at index 1 in $all_columns but my $new_column_index is 0. There is probably an offset somewhere, if a contributor can check if my analyse is correct I would appreciate that :)

SteadEXE avatar Jul 19 '22 09:07 SteadEXE

Just to be sure, did you add yourself as the Project's manager or add one of your groups as the manager group in its form? The global Kanban lets all users have their own view, but individual project Kanbans can only be modified by managers.

cconard96 avatar Jul 21 '22 11:07 cconard96

I tried on a project where I am member of a group manager of the project --> Can't reorder tasks I tried on a project where I am the manager --> Can't reorder tasks

We didn't used the global kanban yet, those issues are only confirmed yet to individual ones.

Edit: I can't reorder cards or columns on global kanban. I just did tested it on a newly created project aswell (no corrupted state in database)

SteadEXE avatar Jul 21 '22 12:07 SteadEXE

Is there any work around yet?

SteadEXE avatar Jul 27 '22 08:07 SteadEXE

I just tried, bug is still there in 10.0.3

SteadEXE avatar Sep 14 '22 13:09 SteadEXE

I've not had any luck recreating the issue yet.

cconard96 avatar Sep 14 '22 23:09 cconard96

I was able to reproduce it like it:

  • Create a project
  • Add yourself to manager user
  • Go to Kanban
  • In the default column create task 1, 2, 3 and 4 (I did it from Kanban view, with the "+" next to the task count).
  • Try to move task 4 before task 2 for example.
  • Refresh, the tasks order reset.

If I add a 2nd existing column, sometime re-ordering work in it, sometime not. Even if it works in the 2nd column, if I move all the tasks to the first column, it no longer works.

I hope it helps

SteadEXE avatar Sep 19 '22 06:09 SteadEXE

There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue. If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.

github-actions[bot] avatar Dec 02 '22 08:12 github-actions[bot]