signac icon indicating copy to clipboard operation
signac copied to clipboard

Block merging with incomplete PR check list

Open cbkerr opened this issue 4 years ago • 4 comments

Feature description

After streamlining the PR template to include a checklist that must be completed (#686), I think having an automatic check would be a helpful reminder to reviewers. Would it be too heavy handed?

However, there is no way yet to have github automatically block merging with an incomplete "task list". (https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists)

Proposed solution

With some quick searching this seems like an option: https://github.com/stilliard/github-task-list-completed. Note the external privacy policy: https://blog.stapps.io/privacy/#appssuchastasklistcompleted

cbkerr avatar Mar 04 '22 16:03 cbkerr

A different but somewhat related request: it would be nice if labeling a PR as "blocked" would actually prevent merging until that label is removed to avoid accidental merges.

vyasr avatar Mar 14 '22 02:03 vyasr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 14:06 stale[bot]

@cbkerr are you still interested in adding this to signac (and maybe porting it to other repos as well if it works well here)?

vyasr avatar Nov 02 '22 04:11 vyasr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '23 21:01 stale[bot]