signac-flow
signac-flow copied to clipboard
glotzerlab
Feature: Add LogOperations to execution hooks
Add builtin logging for execution hooks.
Description
Add LogOperations and tests for LogOperations to execution hooks.
Motivation and Context
Provides built in logging hooks for users. Partially addresses #637 and #508.
Checklist:
- [x] I am familiar with the Contributing Guidelines.
- [x] I agree with the terms of the Contributor Agreement.
- [x] My name is on the list of contributors.
- [x] The changes introduced by this pull request are covered by existing or newly introduced tests.
- [ ] The package documentation and framework documentation in signac-docs are up to date with these changes.
- [x] I have updated the changelog and added any related issue and pull request numbers for future reference.
Codecov Report
Merging #661 (672726b) into main (02fc644) will increase coverage by
0.26%. Report is 2 commits behind head on main. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 69.28% 69.55% +0.26%
==========================================
Files 44 45 +1
Lines 4295 4332 +37
Branches 1047 1051 +4
==========================================
+ Hits 2976 3013 +37
Misses 1108 1108
Partials 211 211
| Files | Coverage Δ | |
|---|---|---|
| flow/hooks/__init__.py | 100.00% <100.00%> (ø) |
|
| flow/hooks/hooks.py | 88.23% <ø> (ø) |
|
| flow/hooks/log_operations.py | 100.00% <100.00%> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Same as the question on #739, @klywang what is this PR waiting on? Reviews? Do we need to ping people to have a look, or is there more work to be done first?
Same as the question on #739, @klywang what is this PR waiting on? Reviews? Do we need to ping people to have a look, or is there more work to be done first?
@vyasr It's waiting on a review.
@kidrahahjo If you have time, could you take a look at this PR again?