hoomd-blue icon indicating copy to clipboard operation
hoomd-blue copied to clipboard

Relax MPCD virtual particle filler design

Open mphoward opened this issue 4 years ago • 6 comments

Description

The virtual particle filler specializations currently need to compute the total number of particles to add so that the particle arrays are sized by the base class. It would be helpful for geometries where this number is not easily calculated (e.g., in MPI with domains slicing through boundaries) to allow the deriving filler to have more control over how it determines the number of virtual particles (e.g., random sampling with rejection). This should be a small change at the C++ level but tweaks the API of the fillers a little bit. I think this should go into v3 breaking changes for MPCD.

I will work on this.

mphoward avatar Sep 04 '20 14:09 mphoward

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 23 '22 19:03 github-actions[bot]

This issue has been automatically closed because it has not had recent activity.

github-actions[bot] avatar Apr 03 '22 19:04 github-actions[bot]

This is being worked on by someone in a fork:

https://github.com/YMWani/hoomd-blue/tree/feature/mpcd-sphere

That branch will need updates to v3 when it is ready, but I will handle that as part of the other v3 migration tasks.

mphoward avatar Jun 08 '22 17:06 mphoward

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Feb 23 '23 19:02 github-actions[bot]

This issue has been automatically closed because it has not had recent activity.

github-actions[bot] avatar Mar 06 '23 19:03 github-actions[bot]

We will need to address this as part of our new work.

mphoward avatar Feb 02 '24 01:02 mphoward

Resolved in #1737

mphoward avatar Mar 19 '24 20:03 mphoward