hoomd-blue icon indicating copy to clipboard operation
hoomd-blue copied to clipboard

Rotate MPCD geometry and force coordinates

Open mphoward opened this issue 1 year ago • 2 comments

Description

This PR rotates the coordinate systems of some geometries and forces to be in the (x,y) plane rather than (x,z) plane. It mostly involved replacing "z" with "y" in a bunch of places.

This PR should be merged after #1712.

Motivation and context

As explained in #662, the use of (x,z) was a legacy choice from a previous code, but it prevented possible reuse of code for 2d MPCD simulations in HOOMD, which are in the (x,y) plane, if we ever wanted to be able to do this.

Resolves #662

How has this been tested?

Existing tests have been updated by exchanging y and z coordinates as needed.

Change log

N/A

Checklist:

mphoward avatar Feb 01 '24 23:02 mphoward

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Feb 22 '24 19:02 github-actions[bot]

Not stale

mphoward avatar Feb 22 '24 19:02 mphoward

This PR is ready for review. It is the second to last C++ refactoring (one more will be completed related to #772), so getting it merged quickly would be great so that we can focus on finalizing the Python API where most of the user changes are happening.

mphoward avatar Mar 07 '24 15:03 mphoward