hoomd-blue icon indicating copy to clipboard operation
hoomd-blue copied to clipboard

ALJ Overlap Check

Open tommy-waltmann opened this issue 2 years ago • 3 comments

Description

The code which implements the overlap check in ALJ may give false positives and false negatives. When scripts are run using a debug build, this can cause unwanted failures in an assert statement in the evaluator code. This bug does not affect simulation results given a proper initial condition, so it does not affect any hoomd releases.

This issue would require significant developer time and effort to fix, and would require a detailed knowledge of the GJK algorithm as a prerequisite for trying to fix it.

I am making this issue to document that this is something that can happen in the ALJ code in debug builds, not to try and get an immediate solution for the bug.

Platform:

  • Mac
  • Linux
  • GPU
  • CPU

Installation method:

  • Compiled from source

Versions:

  • HOOMD-blue version: 3.0.0

Developer

Any developer who has the time, prerequisite knowledge, and the motivation to do it.

tommy-waltmann avatar Apr 05 '22 15:04 tommy-waltmann

Fixed in #1292

joaander avatar Apr 11 '22 13:04 joaander

I believe that #1292 fixes #1282. This issue was opened by @tommy-waltmann to track future work.

vyasr avatar Apr 12 '22 04:04 vyasr

You are correct.

joaander avatar Apr 12 '22 10:04 joaander

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Dec 28 '22 19:12 github-actions[bot]

This issue has been automatically closed because it has not had recent activity.

github-actions[bot] avatar Jan 07 '23 19:01 github-actions[bot]