glorv

Results 69 comments of glorv

@Connor1996 you need to address the DCO first

``` --- TRY 3 STDERR: tikv config::tests::test_config_template_no_superfluous_keys --- thread 'config::tests::test_config_template_no_superfluous_keys' panicked at src/config/mod.rs:6878:10: called `Result::unwrap()` on an `Err` value: Error { inner: ErrorInner { kind: Wanted { expected: "newline", found:...

https://github.com/tikv/tikv/blob/b4e0bf7bab6ad395b74c0be938119d82ded4cd2a/components/raftstore-v2/src/operation/query/local.rs#L315-L321 The root cause is if `try_get_snapshot` returns Redirect due to `ReadDelegate` is not exist, raft-v2 will always do `try_to_renew_lease` which will triggers a readIndex. This is not true for...

> Does the metrics introduce this regression? cc @glorv Unlikely, local metrics is generally very fast. 🤔

Shall we merge or close this PR, it has opened for more than 1 year through the Chinese PR is merged long ago?

While test integrating tonic into [TiKV](https://github.com/tikv/tikv) to replace [grpc-rs](https://github.com/tikv/grpc-rs), I found that tonic's performance is not as good as grpc-rs as it consumes more cpu. And from the profile, I...