Jed Verity
Jed Verity
Thank you for the report @glebcha . There is no support for this yet, as the lib only supports multi-key bindings with standard modifier keys (and escape is not treated...
@ste93cry It is definitely possible! Someone offered to do that a while back but apparently never got around to it. I welcome a PR that adds them, and am happy...
Sure @salmanm happy to review a pr. Thank you!
I haven't gotten around to this yet but happy to review a PR! Otherwise I should be able to get to it within the next couple of weeks.
Ah sorry, I never replied to this @salmanm . Yes, I think that's the way for now.
@lpillonel We should have minus `-` in there as an option but I show 189 for that https://github.com/glortho/react-keydown/blob/master/src/lib/keys.js#L25. As for plus `+` are you able to do `shift + =`?
Okay what do you like as an api for this @lpillonel ? • `@keydown( 'shift + 191' )` • `Keys.set( '-', 189 )` • `keydown.setLocale( 'SM' )` • some combination...
One way to do this will be to do the detection in `getDerivedStateFromProps` and return state related to keydown state that you can then reference in other lifecycle methods. https://hackernoon.com/replacing-componentwillreceiveprops-with-getderivedstatefromprops-c3956f7ce607
Hi @jamesremuscat -- I'm a bit swamped at the moment but very happy to review a PR if anyone wants to tackle this. Reopening.
You're right @g45t345rt -- it's set up only for simplest response handling at the moment. But we'd be very happy to review a PR that improves upon this limitation! On...