m3u8 icon indicating copy to clipboard operation
m3u8 copied to clipboard

robustness fix to _parse_extinf

Open deutrino opened this issue 13 years ago • 3 comments

function now handles titles with commas, and coerces unset durations to 0

deutrino avatar Oct 06 '12 22:10 deutrino

Thanks for the pull-request, but I think we should not merge it as it is.

  1. I think the solution for titles with commas is ok, but we should add a test case.

  2. The spec does not mention how blank durations should be handled, but I think we should set it to None internally, so we can dump it as blank and not 0. Tests would be nice two.

jbochi avatar Oct 08 '12 13:10 jbochi

Just follow the same way using ATTRIBUTELISTPATTERN should be ok. see _parse_stream_inf and _parse_key

feuvan avatar Jan 17 '13 08:01 feuvan

@jbochi @feuvan and @gordon-morehouse is it still valid to apply or should we wait for test case?

leandromoreira avatar Jun 03 '15 03:06 leandromoreira