sophi-for-wordpress icon indicating copy to clipboard operation
sophi-for-wordpress copied to clipboard

Plugin inaccurately sending empty/null data in author array

Open jeffpaul opened this issue 4 years ago • 1 comments

Describe the bug Somewhere within the changes in #109 and #116 (or potentially elsewhere that I have not accounted for) we introduced the ability to send an array to Sophi of post authors. This presumably takes the WP Core default author and appends whatever other plugins may add as additional authors/bylines (e.g., Co-Authors Plus). It seems that somewhere in these various set up configs that we allow either an empty string or a null reference for an author/byline (I forget specifically how Sophi calls this field) to get passed to Sophi which is then causing the entire data set to be tossed out. We should ensure what we send to Sophi for author/byline does not include an invalid empty string or null reference (though we should ensure we get precise confirmation from the Sophi team on what is / is not permissible on their end before making a change here).

Steps to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Environment information

  • Device:
  • OS:
  • Browser and version:
  • WordPress version:
  • Plugins and version:
  • Theme and version:
  • Site Health Info:

Additional context

jeffpaul avatar Sep 15 '21 17:09 jeffpaul

@YMufleh is this update still needed or does the content processing on the Sophi side of things adequately handle for this and thus mean we can close out this request on the plugin side?

jeffpaul avatar Jan 03 '23 20:01 jeffpaul