File uploads attached after subission still miss the possibility to add a description

[evilaliv3]

File uploads attached after subission still miss the possibility to add a description.

When i refactored the fields in relation to file uploads i added the possibility to add metadata inputs for each file uploaded (e.g. for name, source, description etc)

this feature is still completely missing for what concern the tip page.

[evilaliv3]

@hellais / @vecna

do you have any hint for this? in the future we will have the need for asking post submission fields:

1. in order to ask to additional qualified information to the whistleblower
2. in order to add some receiver-fields that the receiver may use to set status of the submission, markers, tags, etcetera.

in this direction file uploads after the submission may be one kind of this post submission fields and enter in my generalization. @fpietrosanti do you remember that we discussed this during the first TI-it workshop?

[evilaliv3]

@fpietrosanti i do not see a short term way to implement. i think this is the only missing feature that we need to postpone for the moment inside amnesty project. @hellais do you have any hint?

[fpietrosanti]

@evilaliv3 This support is required by many features requested by TI for anti-corruption purposes, in particolare the "qualification" of the Tip, the tagging of the Tip, the rating of the Tip, but anyhow i got the point also for the file upload that's missing a feature because "file upload" become a submission field with a file upload inside

[vecna]

@fpietrosanti I see the point, can be quite easy, has one drawback:

the file uploader support multiple files. so by theory, the best solution will be, near the "preview with tick" image, we can display a "description form" and make it optionally required. this is a little harder because require something in JQFU and a new API or an update of the current. (for every file submitted, you have to provide a description)

or, we can do like you suggest, knowing that, if multiple files are submitted, only one description can be associated.

[fpietrosanti]

@vecna sounds like JQFU is going away as we switch to Flow.js+OpenPGP.js (see irc)

[vecna]

yes anyway, the problem description is the same...

[evilaliv3]

wait :) you are both discussing things not aligned. the following image will make you clear that with latest field refactoring creating the file upload field i've already addressed this issue and for each file uploaded during the submission (also if the whistleblower select them at once) there is the possibility to write multiple descriptions (title, descriptio, etc) definible by the admin in field configuration.

the only problem to be discussed here the replication of this fields (submission fields) on the tip page (post submission fields)

[evilaliv3]

[vecna]

aahh, I got it. well...I feel the tip page has to be completely redesign:

• the receiver list can be too much long, if description get inserted
• the system log need to be printed in a more meaningful way
• the context parameter has to be printed in the tip
• the size has to be more or less the same, both for node publeaks-like with 45 receivers, and other with just one receiver. if you take a look on our demo node, with full description of every hermes member, you'll see.
• file description can be appended under the file description, in the current list, anyway every file need an entry (a size, a filetype, a filename)

[evilaliv3]

quite all this topic are ok @vecna. bot out of topic here apart the last.

what follow is my clarification but let's not discuss them here. open a ticket on the various topic if you need to discuss something:

1. https://github.com/globaleaks/GlobaLeaks/issues/840
2. as told system log should be implemented indipendenlty form comments for various issue i already described somehwere
3. what do you mean? the name is already in the tip and what i'm showing here is not the tip page but is tha submission page of amnesty that is custom designed by joylab and it's not under control to chose what put here and there but simply eventually to suggest missing things. for them the context is the name of the team and it's already shown on the tip page.
4. yep the default for file upload possibilities for the tip page is not changed and i agree that the interface should try to be more compact as possible. for now we have never designed it by the way, we are currently still using the default by jquery file upload that forcefully show some techie staff that we can remove adding simply the possibiliy to add the file description and show the techie staff (metadata end eventually also the size) only on click/mouseover

[dmalacaria]

As so far, even if a description field is added to each attachment, those descriptions are not so easy to associate with their related attchements because are only listed in the tip. In #3286 i suggested, when the whistleblower fill the tip, to have a "description" attribute for each attachment that, after tip's submission, is shown in the attachments informations table that reciver sees.

[evilaliv3]

Thank you for your feedback @dmalacaria

What you propose is already considered and included with out tentative roadmap even though there is no eta as the software is moved forward with community efforts.

Now that files are uploaded only when the submission is completed there are no obstacles to implement a patch for making it possible to store a description along with file uploads.