Guillermo Ruffino

Results 66 comments of Guillermo Ruffino

This change is ok with me, I'm not planning on maintaining that library. I would have liked development to continue on https://github.com/esphome/esphome/pull/2681 in an evolutive manner (merge as is and...

Why is `filters:` there? And map could be "customize" or "rename" Not a big deal though. Also the implementation seems a bit complicated, check ESPHome: includes: where a list of...

I would suggest truncate_min or trim_min

Well introducing a breaking change here won't cause much damage. So this could be min and max and rename the moving ones makes sense to me

> One could even inspect the current configuration structure and issue an appropriate error message (e.g. `min` has been renamed to `sliding_window_min`) to make the migration easier. yes, that's how...

I'm getting a boot loop with this PR, can be reproduced with a bare esp32 and this yaml below (of course, previous code works ok) I strongly recommend reverting this...

@andriej added two more triggers and connect action (see updated description above), works here, please test and let me know so we can try to ship this for the next...

Is in my todo list. Need to do some more debugging on some repeated log messages mostly. It can be used as external component without problems anyway

@andriej do you want to give it another try?

After merging dev here I am experiencing issues in my test environment, I only have one sim800l in a device "in production" which also has several sensors (adc, dallas, servo,...