pyglmnet icon indicating copy to clipboard operation
pyglmnet copied to clipboard

flake8 on tests

Open jasmainak opened this issue 7 years ago • 2 comments
trafficstars

The flake8 linter doesn't seem to be working on the test directory. @pavanramkumar did we disable it at some point? In any case, we should fix this as soon as possible ...

jasmainak avatar Sep 14 '18 21:09 jasmainak

is this simply a case of adding this line to travis.yml:

flake8 --count tests

seems to pass locally except for some docstring complaints

pavanramkumar avatar Sep 17 '18 06:09 pavanramkumar

I think the issue is that it's not complaining when there is a pull request. Try making a pull request where you make flake8 errors in tests/ and Travis does not complain ...

jasmainak avatar Sep 17 '18 15:09 jasmainak