isometric-renders icon indicating copy to clipboard operation
isometric-renders copied to clipboard

Litematica integration

Open kikugie opened this issue 2 years ago • 5 comments

If litematica is installed registers additional command /isorender selection which uses current litematica selection coords for area render.

kikugie avatar Sep 28 '22 09:09 kikugie

Have you checked that this works without Litematica?

BasiqueEvangelist avatar Sep 28 '22 10:09 BasiqueEvangelist

Yes, it doesn't register the command if litematica is not installed @BasiqueEvangelist

kikugie avatar Sep 28 '22 10:09 kikugie

Yes, it doesn't register the command if litematica is not installed @BasiqueEvangelist

I know. I'm mostly asking whether you actually tried it without Litematica, as some funky class loading issues might occur if it's not present.

BasiqueEvangelist avatar Sep 28 '22 12:09 BasiqueEvangelist

I've tested that.

kikugie avatar Sep 28 '22 12:09 kikugie

@gliscowo latest litematica update works with yarn build 11. Its also now synced with with 0.4.1 mod version.

kikugie avatar Oct 20 '22 18:10 kikugie

After looking at this PR again, I'd be happy to merge it code-quality-wise.

I do however need to question why this is even required in the first place. I'm not a very large fan of introducing the baggage of two extra dependencies that need to be kept up to date for a feature that arguably does not bring a lot to the table. Could you explain your specific use-case? To me it would seem that you could simply recreate Litematica's selection with Isometric. Granted, this requires some extra work although to me that does not outweigh having to carry around two extra dependencies

gliscowo avatar Oct 24 '22 20:10 gliscowo

In technical Minecraft community this mod is quite common for showing contraptions. From personal experience and feedback from other people it's more convenient to make a selection with litematica, rather than built-in system or typing in coordinates. This can also be used to make render of just taken schematic or one of multiple active selections in the world.

kikugie avatar Oct 25 '22 11:10 kikugie

Extracted this functionality to a separate mod

kikugie avatar Dec 01 '22 19:12 kikugie