SPSA parameters validation during run submission

Open ppigazzini opened this issue 1 year ago • 1 comments

May 15 19:03:33 tests.stockfishchess.org pserve[801]:   File "/home/fishtest/fishtest/server/fishtest/views.py", line 1526, in tests_view
May 15 19:03:33 tests.stockfishchess.org pserve[801]:     r_iter = p["a"] / (A + iter_local) ** alpha / c_iter**2
May 15 19:03:33 tests.stockfishchess.org pserve[801]:              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
May 15 19:03:33 tests.stockfishchess.org pserve[801]: ZeroDivisionError: float division by zero

The SPSA was submitted with c=0 https://github.com/official-stockfish/fishtest/blob/01d6dbccd4ae9a1719bcd8b07c23be1d72c5286a/server/fishtest/views.py#L1522-L1539

With a validation of the SPSA parameters in the "Create New Test" page we can avoid this issue: https://github.com/official-stockfish/fishtest/blob/01d6dbccd4ae9a1719bcd8b07c23be1d72c5286a/server/fishtest/templates/tests_run.mak#L461-L469

https://github.com/official-stockfish/fishtest/blob/01d6dbccd4ae9a1719bcd8b07c23be1d72c5286a/server/fishtest/templates/tests_run.mak#L1028-L1047

May 15 '24 19:05 ppigazzini

As an additional check I will also enforce c<>0 in the schema. I.e. c in ]0, ∞[. But it will need an upgrade of vtjson since vtsjon does not know about open intervals yet (of course it can be hacked with the current functionality but that would be less elegant).

May 15 '24 20:05 vdbergh