fishtest icon indicating copy to clipboard operation
fishtest copied to clipboard

Fix SPSA for 1 < c < 2 and set c to the real delta

Open Viren6 opened this issue 1 year ago • 0 comments

This PR fixes the issue of it being possible for there to be no delta when c is between 1 and 2. It also sets c to the real delta (after stochastic rounding is applied) so we dont get a wrong update. It also fixes stochastic rounding and clipping. Previously if we had a maximum of 128.5 for example, it was possible for a value of 129 to be ran. Now, we ensure the integer maximums are never exceeded

Viren6 avatar Apr 07 '24 06:04 Viren6