fishtest icon indicating copy to clipboard operation
fishtest copied to clipboard

The pagination widget for finished runs no longer shows the last page

Open vdbergh opened this issue 2 years ago • 8 comments

Note that pagination for the finished runs always worked well (in contrast to the event log).

Screenshot from 2023-05-09 18-42-38

vdbergh avatar May 09 '23 16:05 vdbergh

https://github.com/glinscott/fishtest/pull/1631

dav1312 avatar May 09 '23 16:05 dav1312

#1631

Yes but this was meant to be for the event log. Not for the finished runs (for which there was never any problem).

vdbergh avatar May 09 '23 16:05 vdbergh

I'm just linking the PR bcs u didn't in the issue description. Also the PR doesn't seem to indicate that it was meant only for the events log, it just says "pagination" in general. The last page (currently 5550) of finished tests has a TTFB of 300ms and the same 5550 page in events has a TTFB of 4 seconds, maybe there are some underlying issues in the events.

dav1312 avatar May 09 '23 17:05 dav1312

Yes we tried several times to fix this with appropriate indexes, but without success.

vdbergh avatar May 09 '23 17:05 vdbergh

finished runs had the same problem:

$ time wget -q -O - https://tests.stockfishchess.org/tests/user/Vizvezdenec?page=817 > /dev/null

real	0m19.507s
user	0m0.009s
sys	0m0.003s

vondele avatar May 09 '23 17:05 vondele

Yes of course for the user pages.

But there was never a problem for the generic page.

vdbergh avatar May 09 '23 18:05 vdbergh

Ah, yes, that's correct. But I guess there is little value in treating it in a special way? Not only is there little reason to look at the first tests (apart from some historic curiosity), the pages are accessible, just not one-click away.

vondele avatar May 09 '23 18:05 vondele

I always found it nice that with a single click one could observe the humble beginnings of Fishtest. It is a bit like a museum.

It would be trivial to fix it using an optional argument that restores the old behavior when that is desired.

vdbergh avatar May 09 '23 18:05 vdbergh