fishtest
fishtest copied to clipboard
Hardcoded host name not taken from config
There is a hardcoded host name not taken from config in the worker/games.py
:
+ ["-site", "https://tests.stockfishchess.org/tests/view/" + run["_id"]]
https://github.com/glinscott/fishtest/blob/master/worker/games.py#L1367
Please make the host value (i.e. tests.stockfishchess.org
) and the protocol value (i.e.https
) to be taken from config to form the URL for the "-site" cutechess-cli parameter.
Please also make that the host name from the config to be sanitized (only a-z A-Z, digits, dot and dash) to avoid supposed shell injections.