fishtest icon indicating copy to clipboard operation
fishtest copied to clipboard

Added vnni512; removed forced bmi2 on CPUS with vnni for AVX-512

Open maximmasiutin opened this issue 2 years ago • 2 comments

Added vnni512; removed forced bmi2 on CPUS with vnni for AVX-512. This will allow testing of NNUE-related code for modern processors.

maximmasiutin avatar Apr 02 '23 10:04 maximmasiutin

Read comments.

noobpwnftw avatar Apr 02 '23 19:04 noobpwnftw

The PR has two problems:

  1. it will be a regression for workers tested faster with bmi2 than with avx512
  2. vnni512 and vnni256 architectures have the same conditions on props
         elif (
            "avx512vnni" in props["flags"]
            and "avx512dq" in props["flags"]
            and "avx512f" in props["flags"]
            and "avx512bw" in props["flags"]
            and "avx512vl" in props["flags"]
            and "x86-64-vnni512" in targets
        ):
            arch = "x86-64-vnni512"
        elif (
            "avx512vnni" in props["flags"]
            and "avx512dq" in props["flags"]
            and "avx512f" in props["flags"]
            and "avx512bw" in props["flags"]
            and "avx512vl" in props["flags"]
            and "x86-64-vnni256" in targets
        ):
            arch = "x86-64-vnni256"

ppigazzini avatar Aug 22 '23 13:08 ppigazzini