fishtest icon indicating copy to clipboard operation
fishtest copied to clipboard

Add a basic search to finished tests and rename URL parameters

Open dav1312 opened this issue 3 years ago • 9 comments

Add a basic search to finished tests and rename URL parameters Also remove unused variables

Note: I'm not sure why we use 40 to search for LTC tests since we consider 20+0.2 with 8T as LTC

dav1312 avatar Sep 14 '22 16:09 dav1312

DEV updated.

ppigazzini avatar Oct 03 '22 11:10 ppigazzini

the 30 for LTC is a reasonable separator for sequential runs.. the 'issue' is that we should compute for threaded tests the 'effective' time namely TC * threads (so 8t * 5s/t = 40s should be sequential, while 8t * 20s/t = 160s is LTC).

vondele avatar Oct 03 '22 12:10 vondele

In the longer term just differentiating STC / LTC by the time will be a bit difficult over the full period, i.e. if we change the definitions of STC and LTC.

vondele avatar Oct 03 '22 12:10 vondele

DEV updated.

ppigazzini avatar Oct 04 '22 16:10 ppigazzini

Unsurprisingly, searching by info takes too long 😓

dav1312 avatar Oct 04 '22 16:10 dav1312

Can we speed up pagination making something like this? If the page_size is 25, search page_size + 1 elements (skipping if necessary) to see if there is a next page This would not show the amount of available pages or return the total amount of elements but it would still allow pagination right?

dav1312 avatar Oct 05 '22 07:10 dav1312

Note that there is a google group forum with all the results of fishtest, letting the Google servers do the search for us may be faster: https://groups.google.com/g/fishcooking-results/search?q=antirazor

Of course some queries return several pages if the term happens to be in the title of a master commit (so we may need to parse the results): https://groups.google.com/g/fishcooking-results/search?q=simplify

snicolet avatar Oct 05 '22 08:10 snicolet

Can we speed up pagination making something like this? If the page_size is 25, search page_size + 1 elements (skipping if necessary) to see if there is a next page This would not show the amount of available pages or return the total amount of elements but it would still allow pagination right?

All the pages with pagination open very fast for me and in fishtest development we always check if the code is still working for the very old pages. Clicking 19270 times to get the last Events page is a no go for me :)

With master the navigation to a very old page is slow, but this is due to the skip() function. https://www.mongodb.com/docs/manual/reference/method/cursor.skip/ https://www.codementor.io/@arpitbhayani/why-mongodb-s-cursor-skip-is-slow-90j5f3fst

BTW it seems that there are several approach to try to get a fast and consistent pagination, we can experiment with some of these.

ppigazzini avatar Oct 05 '22 11:10 ppigazzini

All the pages with pagination open very fast for me and in fishtest development we always check if the code is still working for the very old pages. Clicking 19270 times to get the last Events page is a no go for me :)

Ah sorry I meant speed up the search. Instead of trying to find all documents that match an info search, it would only need to find 26 right?

Clicking 19270 times to get the last Events page is a no go for me :)

Yeah It would suck but idk I'm not sure if adding even more indexes is fine...

dav1312 avatar Oct 05 '22 11:10 dav1312