Boris Glimcher comments

Results 33 comments of


                                            Boris Glimcher

Issue: exec: "node": executable file not found in $PATH: unknown

in my image node was already present, so this did a trick for me ``` + - name: Hack container for local development + if: ${{ env.ACT }} + run:...

Issue: exec: "node": executable file not found in $PATH: unknown

@ChristopherHX so is this a recommended workaround for now ? ``` FROM blah... ENV PATH "/home/runner/externals/node20/bin:$PATH" ``` just making sure...

feat(context): adding ctx as first argument

@philippgille if you like the direction, I will continue for the rest of the packages...

feat(context): adding ctx as first argument

@philippgille I'm fine with both hard-cut and mine `WithContext` approach as well I really dislike the `client.WithContext` approach I suggested this PR as I'm not aware of your timeline and...

feat(context): adding ctx as first argument

> Test on Windows (either manually or configure CI to include it) done, see #139

feat(context): adding ctx as first argument

@philippgille what are the next steps ? should I re-base or you taking a different approach ?

feat(context): adding ctx as first argument

@philippgille congrats on the new release! what is the decision on `Context` ?

feat(context): adding ctx as first argument

> Regarding the implementation itself, I like the approach of making the `*WithContext` methods the main one, and the old ones call them with a context they create (some with...

feat(context): adding ctx as first argument

Thank you for calrifications! > * Would you say no additional unit tests are required, as testing the old methods implies calling the new ones implicitly? Correct. Both old and...

feat(context): adding ctx as first argument

> Something else came to mind: With some store configs having a timeout parameter, we should either document that they are completely ignored, _or_ in the `WithContext` methods we could...