glific-frontend icon indicating copy to clipboard operation
glific-frontend copied to clipboard

Dialogbox error description centered

Open saminarp opened this issue 3 years ago • 1 comments

Summary

As discussed in meeting and in the following issue https://github.com/glific/glific-frontend/issues/2164, I have centred the error title An Error Has Occured!. The fixes has been implemented into the file src/components/UI/DialogBox/DialogBox.module.css

Test Plan

I have extended the error message to be able to set the CSS accurately. The current behaviour can be seen here

Error with long message CleanShot 2022-10-17 at 02 32 45@2x Error with short message CleanShot 2022-10-17 at 02 34 06@2x

saminarp avatar Oct 17 '22 06:10 saminarp

Codecov Report

Base: 70.30% // Head: 70.31% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (8580c83) compared to base (dda9252). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2194      +/-   ##
==========================================
+ Coverage   70.30%   70.31%   +0.01%     
==========================================
  Files         233      233              
  Lines        8015     8015              
  Branches     1730     1730              
==========================================
+ Hits         5635     5636       +1     
+ Misses       1796     1795       -1     
  Partials      584      584              
Impacted Files Coverage Δ
src/containers/Flow/FlowList/FlowList.tsx 73.33% <0.00%> (+1.66%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 17 '22 07:10 codecov[bot]

Closing since there has been no activity for a while. @saminarp let me know if you still want to work on this issue. We can reopen the PR after that

mdshamoon avatar Nov 24 '22 10:11 mdshamoon