glific-frontend icon indicating copy to clipboard operation
glific-frontend copied to clipboard

Switching to graphql-ws for websockets

Open mdshamoon opened this issue 2 years ago • 4 comments

Summary

Switching to graphql-ws for websockets. Provides automatic reconnection and stable websocket over graphql ws protocol

Backend branch for testing: https://github.com/glific/glific/pull/2389

mdshamoon avatar Aug 17 '22 14:08 mdshamoon

🚀 Deployed on https://deploy-preview-2121--fervent-hypatia-766178.netlify.app

github-actions[bot] avatar Oct 12 '22 06:10 github-actions[bot]

Codecov Report

Base: 70.31% // Head: 70.39% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (d838d2b) compared to base (7de51e4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
+ Coverage   70.31%   70.39%   +0.08%     
==========================================
  Files         233      232       -1     
  Lines        8015     7993      -22     
  Branches     1730     1727       -3     
==========================================
- Hits         5636     5627       -9     
+ Misses       1795     1783      -12     
+ Partials      584      583       -1     
Impacted Files Coverage Δ
src/config/apolloclient.ts 44.44% <100.00%> (+1.26%) :arrow_up:
src/containers/Flow/FlowList/FlowList.tsx 71.66% <0.00%> (-1.67%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 12 '22 06:10 codecov[bot]



Test summary

151 25 0 4Flakiness 2


Run details

Project Glific
Status Failed
Commit 9107252623 ℹ️
Started Oct 28, 2022 6:24 AM
Ended Oct 28, 2022 7:03 AM
Duration 38:21 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Failures

Chat.spec.ts Failed
1 Chats > should send the message correctly
2 Chats > Send attachment - Image
3 Chats > Send attachment - Audio
4 Chats > Send attachment - Video
5 Chats > Send attachment - Document
6 Chats > Send attachment - Sticker
ChatCollection.spec.ts Failed
1 ChatCollection > should send the message to collection
2 ChatCollection > should send attachment to collection - Image
3 ChatCollection > should send attachment to collection - Video
4 ChatCollection > should send attachment to collection - Audio
This comment includes only the first 10 test failures. See all 25 failures in the Cypress Dashboard.

Flakiness

chat/Chat.spec.ts Flakiness
1 Chats > should send the templates
staffmanagement/StaffManagement.spec.ts Flakiness
1 Staff Management > should delete collection

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 12 '22 07:10 cypress[bot]

@kurund tested with the staff user. It works fine for me. Also I tested with 2500 contacts with command mix run priv/repo/seeds_scale.exs --contacts 2500 and it is working fine at this scale.

mdshamoon avatar Oct 19 '22 05:10 mdshamoon