ssh icon indicating copy to clipboard operation
ssh copied to clipboard

Directly expose the SSH server KEXT, MAC and Cipher algorithms

Open belak opened this issue 7 years ago • 5 comments

I believe this is one of the last pieces needed for https://github.com/go-gitea/gitea/pull/3896

There may be a better interface for this, but it looks like this was designed so you can change the server config in the middle of running so there's a little extra code to make sure the slice gets copied and not just referenced.

belak avatar Nov 02 '18 18:11 belak

Note that I may end up dropping this if we don't need this for gitea.

belak avatar Nov 02 '18 18:11 belak

I did consider exposing the raw SSH config. I suppose that makes more sense since it should only be needed in very specific cases.

Do you have any opinions on copying the config vs just referencing it? I find it a little odd that we create a new server config for every connection.

Thanks for your comments!

belak avatar Nov 02 '18 21:11 belak

I don't have strong feelings either way, just an idea. :)

shazow avatar Nov 02 '18 23:11 shazow

I could go either way. At the moment at least.

progrium avatar Nov 02 '18 23:11 progrium

I'd like to clean up some of the config handling and make it per call to listen, but that doesn't need to happen right now.

belak avatar Nov 03 '18 00:11 belak