registrator icon indicating copy to clipboard operation
registrator copied to clipboard

Add support for skipping tls verification when performing HTTPS check

Open anthcourtney opened this issue 7 years ago • 7 comments

Picking up from #447 and incorporating the update in the consul api which now expects a boolean.

anthcourtney avatar Mar 24 '17 00:03 anthcourtney

Thank you for this :+1:

I just cherry-picked your commit into my fork, but needed to change line 106 to this to get it to compile:

                       check.TLSSkipVerify, _ = strconv.ParseBool(tls_skip_verify)

Commit is here: https://github.com/jharley/registrator/commit/6fcc1210d0ee005597f51ef8f026839994fa1e90

jharley avatar Apr 03 '17 15:04 jharley

@jharley - Thanks, I consumed your change in my fork.

anthcourtney avatar Apr 03 '17 23:04 anthcourtney

please merge

alexinthesky avatar Jun 29 '17 17:06 alexinthesky

Any plans to get this merged and released? Would really love this feature.

mikepietruszka avatar Aug 25 '17 14:08 mikepietruszka

I agree, can we please merge this and push a new master image to dockerhub?

jonfreedman avatar Sep 07 '17 07:09 jonfreedman

Aaah please merge this.

yardik avatar Nov 23 '17 00:11 yardik

@anthcourtney Can you rebase this to resolve the conflicts, and maybe we can get it into mainline?

jharley avatar Jul 12 '18 14:07 jharley