registrator icon indicating copy to clipboard operation
registrator copied to clipboard

Automatically register IPv6 container addresses for services

Open mpalmer opened this issue 9 years ago • 4 comments

This is an alternative to 42wim's work in #229. It takes a different approach, in that IPv6 support is entirely disabled by default, but you only have to specify one flag to registrator (-ipv6) to enable full IPv6 feature parity automatically for all containers (at least, it works the same for IPv4/IPv6 addresses for all the use-cases I've tried it on). You can also manage the overrides on a per-address-family basis (including ignoring IPv4 or IPv6 addresses for a specific port or container), if you want to.

It also has documentation updates, and a test suite for serviceMetaData() to keep the precedence of the various port/portless and address-family variants straight.

mpalmer avatar Jan 11 '16 00:01 mpalmer

I like that sound of all of this. Can anybody else try and review this?

progrium avatar Jan 11 '16 03:01 progrium

Unfortunately, this needs a rebase. Mind doing that so I can give the code a review?

josegonzalez avatar Sep 15 '16 05:09 josegonzalez

We're moving away from registrator, so I'm not able to spend work time on it, nor verify that the PR still works after a rebase.

mpalmer avatar Sep 15 '16 10:09 mpalmer

No worries, that makes sense. Apologies that it took so long to look at this pr :(

josegonzalez avatar Sep 15 '16 15:09 josegonzalez