registrator icon indicating copy to clipboard operation
registrator copied to clipboard

Ensure valid hostnames for SkyDNS

Open JonGretar opened this issue 10 years ago • 5 comments

Slugifies service.Name and service.ID so that we always have a valid dns name for containers with default Id's and so on.

JonGretar avatar Feb 04 '15 11:02 JonGretar

It's cool. But SkyDNS works fine with slashes. SERVICE_ID=box/any-service works well. We get the normal subdomain any-service.box.skydns.local. So. I'm use registrator with fleet. It would be great to determine the replacement rules. For example @. -> / will be very convenient for systemd.

akaspin avatar Feb 14 '15 22:02 akaspin

Yeah didn't realize about the slashes. Added.

JonGretar avatar Feb 14 '15 23:02 JonGretar

NONONO!!! We use slashes!

akaspin avatar Feb 14 '15 23:02 akaspin

What do you mean? Slashes should go through now without being filtered out.

JonGretar avatar Feb 15 '15 00:02 JonGretar

This needs a rebase, but also is this a better solution than in #62?

progrium avatar Sep 01 '15 20:09 progrium