logspout icon indicating copy to clipboard operation
logspout copied to clipboard

supporting containerd directly? (Feature request)

Open CoreTechnologyAG opened this issue 4 years ago • 13 comments

Hello

We use logspout in our docker infrastructure. Now we are planning to switch to kubernetes based on containerd. Kubernetes doesn't support dockerd anymore in the future.

Is there a plan to migrate/enhance logspout to this? Thanks

CoreTechnologyAG avatar Dec 08 '20 07:12 CoreTechnologyAG

Due to lack of development time, this project has pretty much gone into maintenance mode. However, I am certainly open to guiding and reviewing a PR to achieve this goal.

michaelshobbs avatar Dec 08 '20 13:12 michaelshobbs

We use logspout and like it in part b/c of its smaller resource footprint compared to other things out there. Would you be able to please suggest any spiritually similar alternatives?

onpaws avatar Dec 15 '20 16:12 onpaws

@michaelshobbs are you working on it or can I take this task?

merowing1279 avatar Dec 03 '21 20:12 merowing1279

@merowing1279 please by all means feel free to take this. let me know if i can offer any insight or assistance

michaelshobbs avatar Dec 03 '21 20:12 michaelshobbs

ok :) what I'm understanding here is to use instead of docker socket the containerd socket and asking about log the containerd API. Am I right?

merowing1279 avatar Dec 03 '21 20:12 merowing1279

sounds right to me? we also need to sort out how we will test and (maybe?) potentially fallback to the previous functionality. if we don't want to do that then we at least need to document the bare minimum docker/containerd version we support after this change.

michaelshobbs avatar Dec 03 '21 20:12 michaelshobbs

I'm thinking to have the both working version. I will try to prepare a good interface for hiding the type of runtime implementation which is using during starting the logspout.

merowing1279 avatar Dec 03 '21 20:12 merowing1279

sounds good to me

michaelshobbs avatar Dec 03 '21 20:12 michaelshobbs

@CoreTechnologyAG are you still waiting for this feature?

merowing1279 avatar Dec 03 '21 20:12 merowing1279

No we don't need this feature anymore. We switched to filebeat from elastic

CoreTechnologyAG avatar Dec 04 '21 21:12 CoreTechnologyAG

@merowing1279 did you make any progress on this? We are considering the switch to containerd and currently use a derivative of this container.

karlvr avatar Jun 03 '23 21:06 karlvr

@karlvr you can go with containerd.

merowing1279 avatar Jun 24 '23 15:06 merowing1279

@karlvr you can go with containerd.

Do you mean that the current logspout version works with containerd as well? Or do we need a special version of it? Could you elaborate a bit more? Thanks!

rhaex avatar Mar 25 '24 10:03 rhaex