logspout icon indicating copy to clipboard operation
logspout copied to clipboard

Published 20 hours ago • verified publisher icon gliderlabs

Add support for DNS SRV lookups

Open mhamann opened this issue 6 years ago • 6 comments

Fixes https://github.com/gliderlabs/logspout/issues/270

mhamann avatar Oct 20 '17 14:10 mhamann

@michaelshobbs it took me far longer to complete this than I originally intended, but at last, it is ready to go. :-)

mhamann avatar Oct 20 '17 15:10 mhamann

No worries. Thanks for the contribution

michaelshobbs avatar Oct 20 '17 16:10 michaelshobbs

@michaelshobbs what do you need before this can be merged?

mhamann avatar Nov 05 '17 01:11 mhamann

@michaelshobbs can this get merged please? @mhamann are you still using service discovery in logspout, what are you using instead?

ChrisLahaye avatar Jul 12 '19 08:07 ChrisLahaye

this PR has merge conflicts. happy to merge once the feedback and conflicts are resolved.

michaelshobbs avatar Jul 12 '19 14:07 michaelshobbs

@ChrisLahaye I've since moved my environment to Kubernetes. Between k8s services and kube-dns, I no longer need SRV lookups.

I believe I'd originally resolved conflicts and addressed review comments, but I guess it must've fallen through the cracks. Not sure I'll have time to fix this up again, but would be happy for someone else to handle it. Seems like it would still be a good contribution.

mhamann avatar Jul 14 '19 03:07 mhamann