glide icon indicating copy to clipboard operation
glide copied to clipboard

dist gone?

Open plufz opened this issue 2 years ago • 10 comments

Sorry if this is an old issue. My app have stopped building because of the missing dist directory. Is it by design the dist directory is removed from the repo or am I doing something wrong?

plufz avatar Jan 12 '22 15:01 plufz

Yep, it has been removed from the repository but should still be there when you install a package using npm. How are you installing it?

jedrzejchalubek avatar Jan 12 '22 16:01 jedrzejchalubek

how can i use it if i'm not using npm nor sass. Is there a way to still use just with a link to css?

joananeves1091 avatar Jan 19 '22 12:01 joananeves1091

You can directly download specific build file it from the release page: https://github.com/glidejs/glide/releases

jedrzejchalubek avatar Jan 19 '22 17:01 jedrzejchalubek

Ah, alright. I'm in a legacy project using bower. That is probably why...

plufz avatar Feb 02 '22 13:02 plufz

Yeah, I think Bower directly uses repositories as source and, yeah, dist folder on the repo has been removed as it is a good practice to not hold output files directly in git history

jedrzejchalubek avatar Feb 02 '22 15:02 jedrzejchalubek

This is an issue for anybody not using NPM. We deliberately keep NodeJS outside of our build toolchain, and just reference github repos/zips in our composer.json file. There are only pre-built JS assets on the releases page, but no CSS assets.

Please bring back the pre-built /dist folder. It is a a quite common practice in PHP's composer world to include JS libraries directly from git repos.

UPDATE: A similar discussion over at tippy.js proposed to add a github action uploading a ZIP into the assets section

hudri avatar Apr 07 '22 09:04 hudri

Same here. Please bring back the dist folder.

weronikasiuda avatar Apr 27 '22 10:04 weronikasiuda

A note for people looking for a download including the dist folder: We are now using registry.npmjs.org instead of github.

E.g. in our composer.json for PHP/Drupal we now use

{
    repositories: [
        {
            "type": "package",
            "package": {
                "name": "glidejs/glide",
                "version": "3.5.2",
                "type": "drupal-library",
                "dist": {
                    "url": "https://registry.npmjs.org/@glidejs/glide/-/glide-3.5.2.tgz",
                    "type": "tar"
                }
            }
        }    
    ]
}

You can get this url using npm view [package name] dist.tarball, with package name being @glidejs/glide.

Or, in the browser, on the project page on jsdelivr.net, on top of the page, right side of the title, hover over the download icon.

hudri avatar Apr 28 '22 13:04 hudri

@jedrzejchalubek ; please also see https://github.com/cdnjs/packages/pull/1234

xerc avatar Jul 17 '22 18:07 xerc

https://www.npmjs.com/package/glidejs << REMOVE ? https://www.npmjs.com/package/@glidejs/glide

xerc avatar Jul 18 '22 11:07 xerc