quicktype icon indicating copy to clipboard operation
quicktype copied to clipboard

Published 20 hours ago • verified publisher icon glideapps

PHP

Open schani opened this issue 4 years ago • 5 comments

schani avatar Dec 26 '20 23:12 schani

Hello, I wanted to know what is the status of this merge request?

Naoero avatar Apr 20 '22 16:04 Naoero

Although some tests are failing, @schani would this PR be (close to) ready for review?

It seems like with this PR you made some additions for the fork that would get merged via https://github.com/quicktype/quicktype/pull/1595 ?

rvanlaak avatar Jun 10 '22 08:06 rvanlaak

Any progress on this? Have used the VSCode extension a lot for Typescript but now also need to use it for PHP too

ThaDaVos avatar Aug 01 '22 11:08 ThaDaVos

Some news about this PR?

alexsandro-xpt avatar Sep 15 '22 22:09 alexsandro-xpt

When you are looking for PHP models, it might be best to then also use a schema generator written in PHP. Maybe the solution would be to start using https://github.com/api-platform/schema-generator instead?

rvanlaak avatar Sep 21 '22 10:09 rvanlaak

@mabels this is all up-to-date with working test harness in CI -- can you take a look?

dvdsgl avatar Jan 08 '23 01:01 dvdsgl

Awesome! Planning on tagging v7.1 soon? Or will you do more polishing and introduce BC breaks as well?

Also saw that the PHP target was not mentioned at the Readme yet.

rvanlaak avatar Jan 08 '23 10:01 rvanlaak

@rvanlaak want to make a PR? I just got our CI back online and did the bare minimum to accept outstanding PRs with tests. If you'd like to PR the README, I'd much appreciate it :D

dvdsgl avatar Jan 08 '23 17:01 dvdsgl

@dvdsgl sure, there you go! https://github.com/quicktype/quicktype/pull/2168

rvanlaak avatar Feb 10 '23 16:02 rvanlaak