Any interest in these fixes from my fork?
Hey all,
In 2024 there was a lapse in maintenance which blocked me, so I've been maintaining a fork since then. I recently noticed renewed activity and so I'm opening this issue to highlight some of the fixes I made in my fork.
If anyone feels these are useful for upstream, please let me know
Quick summary of fixes because my commits are a mess:
- onGridFocus / onGridBlur events https://github.com/TheSisb/glide-data-grid/commit/b4e7f4ae64b0e5253888a8424e7b66c33d694a00#diff-3e4b00d273a625e520929f36335bd67bab65f8c4c042a4a56b580c1fc706e2e0
- emit onHeaderClicked in row marker column https://github.com/TheSisb/glide-data-grid/commit/999869c17c8a0c095735994a7a465aa4ec3f8969#diff-3e4b00d273a625e520929f36335bd67bab65f8c4c042a4a56b580c1fc706e2e0
- theme row marker icons https://github.com/TheSisb/glide-data-grid/commit/1e6573b636d38da690ff3634d84456314587e900
- fix: use theme.cellHorizontalPadding for group header padding https://github.com/TheSisb/glide-data-grid/commit/a41da333d2ac9211aa11c060ef0fbc29263d3719
- feat: Add content alignment support for grid headers https://github.com/TheSisb/glide-data-grid/commit/681543a641265e08ddb7c0d62c5bceba1a9dc70e
- better column width autosizing https://github.com/TheSisb/glide-data-grid/commit/b2ac2fc2a3094bb97ab795802009f8bda4eb07b0#diff-3e4b00d273a625e520929f36335bd67bab65f8c4c042a4a56b580c1fc706e2e0
- support middle click https://github.com/TheSisb/glide-data-grid/commit/7353c5a68e460aefd71e3a6de0de20bc762a401d
- fix safari column sizing https://github.com/TheSisb/glide-data-grid/commit/9ae926c7d0a4dcc373ac6488d768e618be9b6fc7 + https://github.com/TheSisb/glide-data-grid/commit/5d33233f9e80580ee75bfac328182ea5efbb84db#diff-6a92cd7b4ea6d5f804b100d52eaab851c9a354a3c9ec861acc913ed19b9d88b7
Have you considered releasing your fork? I'd be interested!
You can install it and use it already
"@glideapps/glide-data-grid": "github:TheSisb/glide-data-grid#5d33233f9e80580ee75bfac328182ea5efbb84db",
in your package.json file
@TheSisb, sorry for the late reply. I would be happy to get some of these fixes and improvements merged :) Unfortunately, I only have limited time I can spend on glide-data-grid and will mainly focus on smaller, non-risky/breaking changes. But most of the linked changes look pretty good to get in soon.
LMK if I can assist with a PR review 😎
Let me know which fixes you think are worth bringing over and which ones might not make sense for the main project. Once I have your direction, I can open PRs accordingly and clean up the commits.