glide-code-columns icon indicating copy to clipboard operation
glide-code-columns copied to clipboard

Add URL to luxon text

Open djpirl opened this issue 1 year ago • 9 comments

Context

Make it easier to understand luxon date formatting by adding a hyperlink

Screenshot

SCR-20240124-oatw

djpirl avatar Jan 24 '24 20:01 djpirl

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
glide-code-columns ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 9:00pm

vercel[bot] avatar Jan 24 '24 20:01 vercel[bot]

@cif, not sure how to run glide locally and use this branch to test that my change is working properly in the product. Any tips?

djpirl avatar Jan 24 '24 20:01 djpirl

For that change to render a link I suspect we'd have to convert the markdown in the string to HTML in the property configuration. If you create an issue for that I can look into it, might be a pretty simple change

cif avatar Jan 24 '24 21:01 cif

Created the issue here: https://github.com/glideapps/glide/issues/25182

I just added the URL to see if it would work. I saw that there was a URL previously stored in withAbout with type string. Are you referring to making the change on the Glide side?

Screenshots

withAbout SCR-20240124-pzpo

withAbout type SCR-20240124-pzrs

djpirl avatar Jan 24 '24 23:01 djpirl

Commented in the issue as well https://github.com/glideapps/glide/issues/25182#issuecomment-1910436021. Adding the markdown to the description field will be the way we want to enable this - the builder ignores the about field for yes code configs

cif avatar Jan 25 '24 15:01 cif

Nice! Do you want to merge this or should I once the other PR lands?

djpirl avatar Jan 26 '24 14:01 djpirl

Looks like the prod deploy hasn't started yet and I'll be offline for a few hours. If you see it land feel to merge!

cif avatar Jan 26 '24 16:01 cif

Looks like the prod deploy hasn't started yet and I'll be offline for a few hours. If you see it land feel to merge!

It landed! I would merge, but I'm not authorized apparently. Can you give me permissions?

djpirl avatar Jan 29 '24 06:01 djpirl

I also lack permissions here, @timwellswa can you give us a hand when you get a second?

cif avatar Jan 29 '24 15:01 cif