autotune icon indicating copy to clipboard operation
autotune copied to clipboard

replace autotune element with x-autotune custom element.

Open Kilian opened this issue 6 years ago • 6 comments

Here's the PR for the suggestion in #55. This makes Autotune use a custom element, making it more compliant with the HTML specification.

Kilian avatar Aug 16 '18 19:08 Kilian

Both jest and tslint are happy with the above changes. (You can set up something like Travis to run these automatically for every PR, by the way)

Kilian avatar Aug 16 '18 19:08 Kilian

This breaks production websites. Maybe we should add support for compliant alternatives but not remove the previous tag and attributes?

dvdsgl avatar Aug 17 '18 17:08 dvdsgl

There's a few options

  1. Semantic versioning. Bump the major version because it's a breaking change.
  2. Bump the major version, keep the <autotune>support as well, and add a deprecation message when used. Remove it in the next major version.
  3. Add a function that checks for <autotune> elements, changes them all to <x-autotune> elements and then run the rest of the code.

This is also roughly in order of complexity :)

You already had support for both the autotune and the data-* attributes, so that's not changing other than me updating the documentation and samples to show just the compliant method.

Kilian avatar Aug 18 '18 10:08 Kilian

@dvdsgl any further thoughts on this?

Kilian avatar Oct 01 '18 12:10 Kilian

Sorry for the delay! Added a comment.

dvdsgl avatar Oct 08 '18 20:10 dvdsgl

Sorry for the even bigger delay! I've re-added support for <autotune> and added a test for it as well.

Kilian avatar Jan 23 '19 15:01 Kilian