autotune
autotune copied to clipboard
replace autotune element with x-autotune custom element.
Here's the PR for the suggestion in #55. This makes Autotune use a custom element, making it more compliant with the HTML specification.
Both jest and tslint are happy with the above changes. (You can set up something like Travis to run these automatically for every PR, by the way)
This breaks production websites. Maybe we should add support for compliant alternatives but not remove the previous tag and attributes?
There's a few options
- Semantic versioning. Bump the major version because it's a breaking change.
- Bump the major version, keep the
<autotune>
support as well, and add a deprecation message when used. Remove it in the next major version. - Add a function that checks for
<autotune>
elements, changes them all to<x-autotune>
elements and then run the rest of the code.
This is also roughly in order of complexity :)
You already had support for both the autotune and the data-* attributes, so that's not changing other than me updating the documentation and samples to show just the compliant method.
@dvdsgl any further thoughts on this?
Sorry for the delay! Added a comment.
Sorry for the even bigger delay! I've re-added support for <autotune>
and added a test for it as well.