Guillaume Lessard
Guillaume Lessard
@swift-ci please test
I would like to unblock the rest of Windows testing, so I am inclined to merge this with the addition of a link to issue 137.
@swift-ci please test
@swift-ci please test
@swift-ci please test
No problem! I wasn't sure about the status, and this solution came to mind. You can go ahead and force-push when you are ready.
After reading the documentation for these functions in POSIX, I wonder if we should simply return 0 whenever presented with an empty buffer. It is not required to detect errors...
Returning `-1` is wrong, because it implies an actual error occurred. It is normal to return zero bytes! In all likelihood if the code checks `errno` after this, it will...
> That's not the issue here though: this issue is that the buffer read or written into cannot be null. That's definitely an error. It _would_ be a programmer error...
I'd like to try a different approach, where we can make the syscall regardless on platforms where the parameter has the typical nullability. I don't love the idea of skipping...