servo-shell
servo-shell copied to clipboard
glennw
use system colors for the shell
@flying-sheep Want to file a corresponding issue in rust-cssparser to figure out how to support nonstandard properties like this? The idea of adding platform-specific code to https://github.com/servo/rust-cssparser/blob/master/src/color.rs#L99 to figure these values out isn't particularly appealing :)
nonstandard? where did you get that idea from?
will do. and yeah, that doesn’t sound too clean given that it needs to be resolved at runtime (OS color themes can change at any time and differ between applications)
but there already is the special value Color::CurrentColor, so we’d just need to add 28 more special values.
and yeah, as said in the standard, we could use apperance instead, but i guess that’s more work… just think about what apparance: tab would imply instead of a simple color: WindowText; background: Window; border: 1px solid WindowFrame. besides, the current version of CSS3-UI has no mention of apperance, so the deprecation notice is pretty unhinged (deprecated in favor of something that was decided against?)
fyi: the issue exists, and is the only currently open one: servo/rust-cssparser#2
Huh, TIL. For what it's worth, the TR/ specs should be ignored in favour of http://dev.w3.org/csswg/: http://dev.w3.org/csswg/css-color-3/#css-system, http://dev.w3.org/csswg/css-color/#system-colors, and http://dev.w3.org/csswg/css-ui-4/#appearance-switching
yeah, but as i said there: appearance has only the “button” value, so it’s useless, and system colors are the closest to get a semblance of native appearance.
That issue has been closed, system colors are back in the standard (not all of them, many individual ones have been deprecated):
- https://www.w3.org/TR/css-color-4/#css-system-colors
- https://www.w3.org/TR/css-color-4/#deprecated-system-colors