Glenn Jacobs

Results 195 comments of Glenn Jacobs

Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x with Filament admin panel.

This isn't something we want to incorporate.

@alecritson this could be OK. I'm trying to remember back to when we first made this. Do we need hub updates to go alongside this?

> So far there is no practical need to fetch`AttributeGroup` models based on their `handle`. I think there is no reason why to place this change in the upgrade guide....

Also, could this please target the `0.8` branch?

This PR seems to have lots of updates not associated to the functionality specified. Closing, but feel free to reopen if you can make a PR that is focused on...

> @glennjacobs i think the pint action is not running the check as the dirty flag only look for uncommitted files, not changed files in PR, see [aglipanci/laravel-pint-action#4 (comment)](https://github.com/aglipanci/laravel-pint-action/issues/4#issuecomment-1475163156) Oh,...

@charlielangridge can you please target `main` as this isn't a bug fix.

I am going to close this, as we're not looking to add new functionality to v0.8 now. However, we do want to incorporate this into v1.0 so I will be...

Closing, as I don't believe this is required, as we have tax classes applied to shipping options that allow you to set a zero rate.