Glenn Jacobs

Results 195 comments of Glenn Jacobs

@wychoong thanks for this. Did you have any plans to add in the Tax Rates also?

@alecritson https://github.com/lunarphp/lunar/pull/1424/commits/5812aa92553a041e530220ac48883615556e3565 seems to have broken the tests, can you fix?

@timmydhooghe is this still an active PR?

> > @timmydhooghe is this still an active PR? > > @glennjacobs Normally, this would've been ready to merge by now, but I'm struggling with my health at the moment,...

@timmydhooghe are you going to be completing this PR? Thanks

Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x.

We have discussed this previously, so this is a good reminder. We wanted to pull out the name attributes (and maybe handle, if required) into dedicated fields.

Closing as we already have this planned for the 1.0.0 beta release.

> @glennjacobs and @alecritson, before I spend more time into this, what do you think about using the [spatie/eloquent-sortable](https://github.com/spatie/eloquent-sortable) package for manual sorting instead. It should cover all requirements for...

Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x.