Glenn Jacobs

Results 195 comments of Glenn Jacobs

Do we need to use Lazy Eager Loading? Would it suffice to add it to the Cart model? e.g. ```php class Cart extends Model { protected $with = ['lines']; ```

This is certainly something we need to handle. What the best approach is I'm not sure. I will discuss this tomorrow with the team.

Having discussed this with @alecritson the only sensible approach here is to create the new prices based upon the currency conversion/exchange rate. A single SQL query can insert over 50k...

@nicolalazzaro Yeah, I thought about that approach. I guess we could make it optional for the system to generate the prices. If they're not generated, then they all need to...

The Price datatype only uses currency. Would eager loading of the currency prevent this? Do you have example code to reproduce the problem?

@alecritson do we want to try to get something in beta11 for this? From what I can see Collections and Price data would be helpful.

Jumping in here as this topic is active again. The original purpose for currencies being enabled or not was for storefront display. Perhaps a currency's exchange rate isn't so great...

Right, so when creating a new currency it would have to be disabled by default (assuming we have products in the database). But the currency would still show in the...

@alecritson can this be updated now that the other PR has been merged?