react-collapsible icon indicating copy to clipboard operation
react-collapsible copied to clipboard

Change contentHiddenWhenClosed to set the css visibility instead of the html hidden property

Open arye-eidelman opened this issue 4 years ago • 3 comments

This stops it from interfering with the content's scrollHeight fixing #194.

I've also added two tests for this prop.

arye-eidelman avatar Jun 07 '21 03:06 arye-eidelman

If there were an is-transitioning or in-transition html class then content could be hidden via css selectors alone without needing to be an option in react-collapsible. Something like

.Collapsible.is-closed:not(.is-transitioning) ~ .Collapsible__contentOuter {
  visibility: hidden;
}

arye-eidelman avatar Jun 07 '21 13:06 arye-eidelman

Great that the bug is fixed! When can we expect it to be merged and released?

codeability-ab avatar Jul 01 '21 13:07 codeability-ab

Great that the bug is fixed! When can we expect it to be merged and released?

Just want to make sure we're not going to regress, see my comment here https://github.com/glennflanagan/react-collapsible/issues/194#issuecomment-872289978

d4c8d7c was a fix for #177.

Does PR #195 fix both scenarios?

karltaylor avatar Jul 02 '21 08:07 karltaylor