Glen Mailer

Results 163 comments of Glen Mailer

Yeah, I should have some time tomorrow to take a look and get this sorted Thanks for the prompt

Any idea how to detect if it's an http connection? If so we could skip that header in those scenarios.

Any idea if that's an implementation details or something the `http2` projects officially supports for detection? If there's some confirmation that it's the latter, I'll happily merge a PR which...

Hrm, i thought there was a way to customise the process-update behaviour and the arguments passed to `module.hot.apply`, but it doesn't look like that was ever introduced. The code was...

I think it might be a bit more complicated than that to get the behaviour correct. I think perhaps the right logic might be to not ignore if reload is...

This is a good idea, I'd take a PR which adds this but retains the ability to disable it independently of the error/warning overlay. If whoever is implementing this wants...

Yep, the intention is to mirror the functionality of the original dev server client, so patches that keep this in line are welcome

I'm struggling the follow this scenario. Part of this will be because the existing events I've implemented are not well documented. I'm pretty sure the `sync` event was introduced to...

Thanks for looking into this. It’s probably also worth comparing notes with webpack-hot-client to see what it does