howdoi icon indicating copy to clipboard operation
howdoi copied to clipboard

initialized stats.py

Open joeyouss opened this issue 4 years ago • 4 comments

initialized stats.py and added some lines of code on which howdoi/sta…

joeyouss avatar Jul 29 '21 18:07 joeyouss

@gleitz I cannot seem to understand the conflicts since the conflicts show only in text area, could you help me and also check this PR? it has a bunch of errors as of now but your reviews would help !

joeyouss avatar Sep 08 '21 07:09 joeyouss

Sure, happy to have a look.

If you check out this recent PR, you'll see that we now have a new function to fetch cache keys.

You can see the conflicts if you go to https://github.com/gleitz/howdoi/pull/414/conflicts or if, from your branch, you run git pull --rebase (assuming that you've set my howdoi master branch as the repo and branch you created your fork from). You can read more about rebasing at https://stackoverflow.com/questions/15602037/git-rebase-upstream-master-vs-git-pull-rebase-upstream-master

In any case, you'll just need to pull down the latest changes from my howdoi repo and change your function to call _get_from_cache(cache_key)

Screen Shot 2021-09-08 at 1 16 17 PM

gleitz avatar Sep 08 '21 17:09 gleitz

Thanks ! I will take a look today for this

joeyouss avatar Sep 08 '21 19:09 joeyouss

So, here is the update:

  • the stats.py file works great but we do not have unit tests for it
  • rebase did not work for my laptop hence i added the function manually
  • once stats.py gets approved, we need to add termgraph dependencies in requirements.txt so that it gets installed everytime someone works on howdoi

joeyouss avatar Oct 12 '21 17:10 joeyouss