Gleb Mazovetskiy

Results 244 comments of Gleb Mazovetskiy

@lirantal If you could file a CVE that'd be great! I have no experience with those.

We couldn't find any evidence pointing towards either of our accounts. None of our other gems have been affected, and RubyGems doesn't have any sort of log to determine who...

@mlprojn `malloc.h` is a long-deprecated header and should not be included at all, on any platform. I sent a pull request on the same day I filed the issue but...

I propose the spec be changed to something like this: #436

@wooorm Good catch, I will add the legacy elements to the list. **Update:** Added in https://github.com/jgm/CommonMark/pull/436/commits/3f292b5108be8ac75aa0ed8b322406b42243495a https://github.com/jgm/CommonMark/pull/436/commits/ac762f746f8bf15ff3ff55b0c6edc60079a970ad.

I think another class of tags that should not start an HTML block is self-closing tags. ~~I'll add them as well.~~ What do you think? If you agree, then I...

I've started a discussion about self-closing tags and tags closed at the end of the same line that has the starts them here: https://talk.commonmark.org/t/reason-for-starting-an-html-block-when-the-closing-tag-is-on-the-same-line/2290/1

Looking at the design of the upcoming module system, it'll be pretty much the same for this purpose (am I missing something?). Looks good to me.

Stack allocation is free but heap isn't; how is this an optimization?

Strange but I haven't been able to get nearly as much speed up. Still good though, went from 60s to 30s when compiling single-core.